[webkit-reviews] review denied: [Bug 75563] remove CSSBorderImageValue : [Attachment 122897] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 75563: remove CSSBorderImageValue
https://bugs.webkit.org/show_bug.cgi?id=75563

Attachment 122897: Patch
https://bugs.webkit.org/attachment.cgi?id=122897&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122897&action=review


> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:505
> +    RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
> +    list->append(imageValue.release());
> +
> +    if (borderSlices || outset) {

This code appears to be duplicated in CSSParser.cpp.  Can we make a helper
function for it?  Maybe put it in CSSBorderImageValue.* for now.  In the long
run, I think we want to get rid of the code in CSSParser.cpp and then can move
the code into CSSComputedStyleDeclaration.cpp.

> Source/WebCore/css/CSSStyleSelector.cpp:4326
> +	       // Set the appropriate rules for stretch/round/repeat of the
slices

Nit: add a period.