[webkit-reviews] review granted: [Bug 73233] [chromium] Create a base-class CCAnimation to represent compositor animations : [Attachment 121870] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 18 12:32:12 PST 2012


Kenneth Russell <kbr at google.com> has granted vollick at chromium.org's request for
review:
Bug 73233: [chromium] Create a base-class CCAnimation to represent compositor
animations
https://bugs.webkit.org/show_bug.cgi?id=73233

Attachment 121870: Patch
https://bugs.webkit.org/attachment.cgi?id=121870&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121870&action=review


rs=me based on nduca's review. Nice tests.

>
Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp
:67
> +    for (size_t i = 0; i < m_activeAnimations.size(); ++i)

Note: it's OK to use braces for a for loop like this, since its body is more
than one line long.


More information about the webkit-reviews mailing list