[webkit-reviews] review granted: [Bug 76265] Cache RenderStyle pointer as a method to avoid performance regression for region styling : [Attachment 122448] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 76265: Cache RenderStyle pointer as a method to avoid performance
regression for region styling
https://bugs.webkit.org/show_bug.cgi?id=76265

Attachment 122448: Patch
https://bugs.webkit.org/attachment.cgi?id=122448&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122448&action=review


r=me with minor changes suggested.

> Source/WebCore/rendering/RenderBlock.cpp:247
> +    RenderStyle* newStyle = style();

This one isn't buying you anything. Only used once.

> Source/WebCore/rendering/RenderBlock.cpp:2049
> +    RenderStyle* cstyle = child->style();

Call this childStyle please, not cstyle.

> Source/WebCore/rendering/RenderBlock.cpp:2146
> +    if (cstyle->marginAfterCollapse() == MSEPARATE) {

childStyle not cstyle.