[webkit-reviews] review granted: [Bug 76547] Signal to skia to force A8 text from LCD output, but only when we have to disable LCD because we're in a layer : [Attachment 122943] Patch

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted Mike Reed
<reed at google.com>'s request for review:
Bug 76547: Signal to skia to force A8 text from LCD output, but only when we
have to disable LCD because we're in a layer
https://bugs.webkit.org/show_bug.cgi?id=76547

Attachment 122943: Patch
https://bugs.webkit.org/attachment.cgi?id=122943&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122943&action=review


OK.  r=me

> Source/WebCore/ChangeLog:10
> +	   Existing tests should confirm nothing is broken. Antialiased text
> +	   is disabled in layouttests, so they should be unaffected by the
> +	   difference in antialiasing quality.

Not your fault, but we really should come up with a way to override AA settings
for specific layout tests.  This could be done by adding to the JS API in
testing/Internals (as we do for accelerated drawing, e.g.).  This would allow
us to test changes like this.