[webkit-reviews] review denied: [Bug 76532] Web Inspector: Implement screen resolution emulation backend : [Attachment 122925] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 76532: Web Inspector: Implement screen resolution emulation backend
https://bugs.webkit.org/show_bug.cgi?id=76532

Attachment 122925: Patch
https://bugs.webkit.org/attachment.cgi?id=122925&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122925&action=review


> Source/WebCore/inspector/Inspector.json:304
> +		   "name": "setScreenSizeOverride",

"hidden": true

> Source/WebCore/inspector/InspectorCSSAgent.cpp:238
> +    m_instrumentingAgents->setInspectorCSSAgent(this);

Is this a part of this change? It seems like you ended up putting screen size
logic into the page agent.

> Source/WebCore/inspector/InspectorPageAgent.cpp:575
> +void InspectorPageAgent::setScreenSizeOverride(ErrorString* errorString,
const int width, const int height)

When navigating, you need to call this method upon agent's ::restore. You will
need to use width and height from the cookie in that case.

> Source/WebCore/inspector/InspectorPageAgent.cpp:584
> +    if (height < 0) {

Combine these all into a single check.

> Source/WebCore/inspector/InspectorPageAgent.cpp:611
> +	       m_originalFixedLayoutSize = adoptPtr(new
IntSize(mainFrame()->view()->fixedLayoutSize()));

// Turning on.