[webkit-reviews] review denied: [Bug 74720] [Qt] Handle the layers visible rect calculation on the web process. : [Attachment 122920] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 74720: [Qt] Handle the layers visible rect calculation on the web process.
https://bugs.webkit.org/show_bug.cgi?id=74720

Attachment 122920: Patch
https://bugs.webkit.org/attachment.cgi?id=122920&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122920&action=review


> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:335
> +   
webPageProxy->drawingArea()->setVisibleContentsRectAndScale(IntRect(IntPoint(),
viewportSize), 1.0);

You don't need the .0 (coding style)

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:109
> +	   child->setVisibleContentRectAndScale(m_visiblePageContentsRect,
m_contentsScale);

I doubt this compiles... you named the variable differently in the header :)

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:119
> +   
toWebGraphicsLayer(layer)->setVisibleContentRectAndScale(m_visiblePageContentsR
ect, m_contentsScale);

Instead of doing all this propagation, can we add a function to
LayerTreeTileClient?