[webkit-reviews] review granted: [Bug 76453] [CSSRegions]Fix region style code in CSSStyleSelector : [Attachment 122916] Patch 2

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 76453: [CSSRegions]Fix region style code in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=76453

Attachment 122916: Patch 2
https://bugs.webkit.org/attachment.cgi?id=122916&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=122916&action=review


r=me, with a few nits

> Source/WebCore/css/CSSStyleSelector.cpp:674
> +void CSSStyleSelector::collectMatchingRulesForRegion(RuleSet* rules, int&
firstRuleIndex, int& lastRuleIndex, bool includeEmptyRules)
> +{
> +    if (m_regionForStyling) {

You should use early return here:

if (!m_regionForStyling)
    return;

> Source/WebCore/css/CSSStyleSelector.cpp:2245
> +inline bool CSSStyleSelector::isInsideRegionRule(CSSMutableStyleDeclaration*
styleDeclaration)
> +{

This would be nicer as a static non-member inline. The caller should test if it
needs to be called (m_regionForStyling is set).