[webkit-reviews] review granted: [Bug 76253] CSS Shaders: Parse float parameters for the custom() filter syntax : [Attachment 122909] Patch V4

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 76253: CSS Shaders: Parse float parameters for the custom() filter syntax
https://bugs.webkit.org/show_bug.cgi?id=76253

Attachment 122909: Patch V4
https://bugs.webkit.org/attachment.cgi?id=122909&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122909&action=review


Looks great to me. Much better readable, eh? :-)

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:730
> +    // FIXME: Add here computed style for the other types: boolean,
transform, matrix, texture.

I'd ASSERT(parameter) here as well.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:861
> +	       const CustomFilterParameterList& parameters =
customOperation->parameters();
> +	       if (!parameters.size())
> +		   break;
> +		   
> +	       RefPtr<CSSValueList> parametersCSSValue =
CSSValueList::createCommaSeparated();
> +	       
> +	       size_t parametersSize = parameters.size();

I'd write this as:
size_t parametersSize = parameters.size();
if (!parametersSize)
    break;
RefPtr<CSSValueList> ....

you can also omit the extra newline.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:871
> +	       

One newline too much.