[webkit-reviews] review granted: [Bug 76444] CSS Shaders: Add a Settings flag to enable/disable CSS Shaders at runtime : [Attachment 122771] Patch V1

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 76444: CSS Shaders: Add a Settings flag to enable/disable CSS Shaders at
runtime
https://bugs.webkit.org/show_bug.cgi?id=76444

Attachment 122771: Patch V1
https://bugs.webkit.org/attachment.cgi?id=122771&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122771&action=review


Looks sane, r=me with some comments:

> Source/WebCore/css/CSSParser.cpp:6914
> +		   if (findDocument()) {

if (Document* document = findDocument()) {
    Settings* settings = document->settings()....

> Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:83
>  // Defaults to false.

This comment is not correct, eh? Please update it to true.