[webkit-reviews] review denied: [Bug 76445] [Qt] build-webkit does not detect the number of CPUs : [Attachment 122866] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 18 01:21:30 PST 2012


Csaba Osztrogonac <ossy at webkit.org> has denied Seo Sanghyeon
<sh4.seo at samsung.com>'s request for review:
Bug 76445: [Qt] build-webkit does not detect the number of CPUs
https://bugs.webkit.org/show_bug.cgi?id=76445

Attachment 122866: Patch
https://bugs.webkit.org/attachment.cgi?id=122866&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
The idea is absolutely good, but now it would overload out buildbot servers. 
We run 3-4 bots on all machine with -jXXX set with MAKEFLAGS environment.

It think we should move forward to GTK way. You can set -jXXX manually 
to add it to WebKitMakeArguments environment variable. If you don't do it, 
numberOfCPUs() is the default value.

Please don't land the fix before we fix our bots.


More information about the webkit-reviews mailing list