[webkit-reviews] review denied: [Bug 73309] [Qt] GC should be parallel on Qt platform : [Attachment 122739] fixed the unresolved external symbol problem on Windows platform

[bugzilla-daemon at webkit.org]

Zoltan Herczeg <zherczeg at webkit.org> has denied Roland Takacs
<Takacs.Roland at stud.u-szeged.hu>'s request for review:
Bug 73309: [Qt] GC should be parallel on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=73309

Attachment 122739: fixed the unresolved external symbol problem on Windows
platform
https://bugs.webkit.org/attachment.cgi?id=122739&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122739&action=review


> Source/JavaScriptCore/wtf/MainThread.cpp:-92
> -
>  #if !PLATFORM(MAC)
> -

Why did you removed these lines?

> Source/JavaScriptCore/wtf/MainThread.cpp:-107
> -
>  #else
> -

Ditto.

> Source/JavaScriptCore/wtf/MainThread.cpp:255
> +	   // This happens if we're running in a process that doesn't care
about
> +	   // MainThread.

Could you write a better explanation here?

Ok, basically I would split this patch into two:

One which adds the number of processor cores part, and a followup patch which
adds the parallel gc feature.