[webkit-reviews] review denied: [Bug 76519] Use RenderTheme more in HTMLSelectElement Rather than ifdefs : [Attachment 122881] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Jun Mukai <mukai at chromium.org>'s
request for review:
Bug 76519: Use RenderTheme more in HTMLSelectElement Rather than ifdefs
https://bugs.webkit.org/show_bug.cgi?id=76519

Attachment 122881: Patch
https://bugs.webkit.org/attachment.cgi?id=122881&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122881&action=review


> Source/WebCore/html/HTMLSelectElement.cpp:985
> +	   UNUSED_PARAM(event);

UNUSED_PARAM(event) is not needed. Please remove it.

> Source/WebCore/platform/gtk/RenderThemeGtk.h:85
> +    virtual bool popsMenuByArrowKeys() const { return true; }

Please add 'OVERRIDE' between const and {.

> Source/WebCore/rendering/RenderTheme.h:184
> +    // Method for <select> elements.
> +    virtual bool popsMenuByArrowKeys() const { return false; }
> +    virtual bool popsMenuBySpaceOrReturn() const { return false; }
> +

RenderTheme::delegatesMenuListRendering() is for <select> too.	Please move
these declarations beside delegatesMenuListRendering().

> Source/WebCore/rendering/RenderThemeChromiumLinux.h:77
> +	   virtual bool popsMenuBySpaceOrReturn() const { return true; }

Please add 'OVERRIDE' between const and {.

> Source/WebCore/rendering/RenderThemeMac.h:83
> +    virtual bool popsMenuByArrowKeys() const { return true; }

ditto.

> Source/WebCore/rendering/RenderThemeSafari.h:88
> +    virtual bool popsMenuByArrowKeys() const { return true; }
> +

You should not modify RenderThemeSafari, which is for Apple Windows port.