[webkit-reviews] review granted: [Bug 76500] IndexedDB: Check for permission before using IndexedDB from a worker. : [Attachment 122848] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 17 21:03:41 PST 2012


David Levin <levin at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 76500: IndexedDB: Check for permission before using IndexedDB from a
worker.
https://bugs.webkit.org/show_bug.cgi?id=76500

Attachment 122848: Patch
https://bugs.webkit.org/attachment.cgi?id=122848&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122848&action=review


> Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:115
> +	       m_webWorkerClientImpl->postTaskForModeToWorkerContext(

No new line needed here but if you add one then you need {} for this.

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:136
> +	     bridge->signalCompleted(false, mode);

indentation isn't correct.


More information about the webkit-reviews mailing list