[webkit-reviews] review granted: [Bug 76482] [CG] Rasterized scaling of transformed SVG shapes with gradient fill and -webkit-svg-shadow applied : [Attachment 122838] patch v.2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 17 19:28:07 PST 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 76482: [CG] Rasterized scaling of transformed SVG shapes with gradient fill
and -webkit-svg-shadow applied
https://bugs.webkit.org/show_bug.cgi?id=76482

Attachment 122838: patch v.2
https://bugs.webkit.org/attachment.cgi?id=122838&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122838&action=review


> Source/WebCore/platform/graphics/transforms/AffineTransform.cpp:257
> +    double width2, height2;
> +    width2 = size.width() * xScale();
> +    height2 = size.height() * yScale();

Just do:

double width2 = 
double height2 = 

Why the '2'?

> Source/WebCore/platform/graphics/transforms/AffineTransform.cpp:266
> +    double width2, height2;
> +    width2 = size.width() * xScale();
> +    height2 = size.height() * yScale();

Ditto.


More information about the webkit-reviews mailing list