[webkit-reviews] review granted: [Bug 76177] SVG group getBBox returns 0, 0, 0, 0 for a group of perpendicular paths : [Attachment 122806] Fix getBBox for perpendicular paths

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Philip Rogers <pdr at google.com>'s
request for review:
Bug 76177: SVG group getBBox returns 0,0,0,0 for a group of perpendicular paths
https://bugs.webkit.org/show_bug.cgi?id=76177

Attachment 122806: Fix getBBox for perpendicular paths
https://bugs.webkit.org/attachment.cgi?id=122806&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122806&action=review


Does the test cover the “united with 0,0,0,0” issue?

> Source/WebCore/rendering/svg/SVGRenderSupport.cpp:194
> +	   if (isFirstChild)
> +	       isFirstChild = false;

No need for the if here. An unconditional assignment does the same thing.