[webkit-reviews] review denied: [Bug 75306] ShadowContentElement query should be able to have fallback element. : [Attachment 122718] Patch

Tue Jan 17 17:43:49 PST 2012

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 75306: ShadowContentElement query should be able to have fallback element.
https://bugs.webkit.org/show_bug.cgi?id=75306

Attachment 122718: Patch
https://bugs.webkit.org/attachment.cgi?id=122718&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122718&action=review

Basically looks fine. Could you add some more tests?

> Source/WebCore/dom/NodeRenderingContext.cpp:85
> +	       if (!shadowContentElement->inclusions()->first()) {

Could you make this conditional a method on ShadowContentElement?
hasInclusion() or something?

> LayoutTests/fast/dom/shadow/shadow-contents-fallback.html:1
> +<!DOCTYPE html>

Oops, I meant to talk about content inside shadow inside content.
Such pattern should hit tricky flattening path.