[webkit-reviews] review granted: [Bug 76484] Check style on test_expectations.txt files before commit : [Attachment 122829] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 17 16:24:16 PST 2012
Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 76484: Check style on test_expectations.txt files before commit
https://bugs.webkit.org/show_bug.cgi?id=76484
Attachment 122829: Patch
https://bugs.webkit.org/attachment.cgi?id=122829&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122829&action=review
Nice approach. Thanks.
> Tools/Scripts/webkitpy/tool/steps/commit.py:60
> + if not len(test_expectations_files):
> + return
You can just say:
if not test_expectations_files:
the empty list is falsy.
More information about the webkit-reviews
mailing list