[webkit-reviews] review granted: [Bug 75851] NULL ptr in WebCore::RenderSVGInlineText::localCaretRect : [Attachment 122810] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Stephen Chenney
<schenney at chromium.org>'s request for review:
Bug 75851: NULL ptr in WebCore::RenderSVGInlineText::localCaretRect
https://bugs.webkit.org/show_bug.cgi?id=75851

Attachment 122810: Patch
https://bugs.webkit.org/attachment.cgi?id=122810&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122810&action=review


It's still sad that we can't add an automated test.

> ManualTests/svg-modify-deleted-selection.svg:12
> +    _Selection_0=getSelection();
> +    _Selection_0.setBaseAndExtent(document,5,document,5);
> +    _Selection_0.deleteFromDocument();
> +    _Selection_0.modify('extend','backward','line');

Why do we need _Selection_0? You can just call getSelection() on every line.