[webkit-reviews] review granted: [Bug 76467] [Mac] Add a flag telling plug-in if it can enter sandbox : [Attachment 122789] proposed patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 76467: [Mac] Add a flag telling plug-in if it can enter sandbox
https://bugs.webkit.org/show_bug.cgi?id=76467

Attachment 122789: proposed patch
https://bugs.webkit.org/attachment.cgi?id=122789&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122789&action=review


> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:503
> +	   case WKNVAllowedToEnterSandbox:
> +	       *(NPBool*)value = true;
> +	       break;

Shouldn't this be true only when running in the plug-in process? (Not that it
really matters since we don't support in-process plug-ins with WebKit2).