[webkit-reviews] review granted: [Bug 76455] Web Inspector: Refactor JavaScriptOutlineDialog: extract FilteredItemSelectionDialog and reuse DialogDelegate. : [Attachment 122779] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 76455: Web Inspector: Refactor JavaScriptOutlineDialog: extract
FilteredItemSelectionDialog and reuse DialogDelegate.
https://bugs.webkit.org/show_bug.cgi?id=76455

Attachment 122779: Patch
https://bugs.webkit.org/attachment.cgi?id=122779&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122779&action=review


> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:38
> +    WebInspector.DialogDelegate.call(this);

It's a bit confusing that the FilteredItemSelectionDialog is itself a dialog
delegate not a dialog descendant.

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:213
> +    _filterFunctions: function()

_filterFunctions -> _filterItems

> Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:431
> +WebInspector.FilteredItemSelectionDialogDelegate.prototype = {

Maybe SelectionDialogContentProvider?