[webkit-reviews] review denied: [Bug 76391] Crash at WebCore::MediaControlRootElement::makeOpaque + 97 : [Attachment 122659] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 17 09:32:21 PST 2012
Daniel Bates <dbates at webkit.org> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 76391: Crash at WebCore::MediaControlRootElement::makeOpaque + 97
https://bugs.webkit.org/show_bug.cgi?id=76391
Attachment 122659: Patch
https://bugs.webkit.org/attachment.cgi?id=122659&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
This patch needs to be rebased as it no longer applies cleanly because the
function MediaControlRootElement::makeOpaque() has changed significantly. In
particular, the line this patch changes no longer exists as it was removed in
<http://trac.webkit.org/changeset/97157> (bug #58157). This changeset also
moved the implementation of MediaControlRootElement::makeOpaque() into
MediaControlPanelElement::makeOpaque() in file
/Source/WebCore/html/shadow/MediaControlElements.cpp:
<http://trac.webkit.org/browser/trunk/Source/WebCore/html/shadow/MediaControlEl
ements.cpp?rev=105163#L207>.
More information about the webkit-reviews
mailing list