[webkit-reviews] review denied: [Bug 76403] Web Inspector: ConsoleMessage.cpp and InspectorResourceAgent.cpp doesn't conform to Inspector.json : [Attachment 122763] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 76403: Web Inspector: ConsoleMessage.cpp and InspectorResourceAgent.cpp
doesn't conform to Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=76403

Attachment 122763: Patch
https://bugs.webkit.org/attachment.cgi?id=122763&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122763&action=review


> Source/WebCore/inspector/Inspector-0.1.json:1
>  {

The only change to the Inspector-0.1.json we accept are the ones where we know
that the behavior of the tool on the date of the Inspector-0.1.json forking did
not conform it already.

> Source/WebCore/inspector/Inspector-0.1.json:9
> +		   "name": "enable",

Not all of the browsers supporting 0.1 have these methods, so you should not
add them.