[webkit-reviews] review denied: [Bug 67936] REGRESSION(r81225): ORWT should ignore reftests : [Attachment 122753] proposed fix

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied Balazs Ankes
<Ankes.Balazs at stud.u-szeged.hu>'s request for review:
Bug 67936: REGRESSION(r81225): ORWT should ignore reftests
https://bugs.webkit.org/show_bug.cgi?id=67936

Attachment 122753: proposed fix
https://bugs.webkit.org/attachment.cgi?id=122753&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122753&action=review


LGTM, but the changelog isn't so talkative, please fix it.

> Tools/ChangeLog:4
> +	   [ORWT] Call isUsedInReftest() in findTestsToRun if you pass complete
test name.
> +	   https://bugs.webkit.org/show_bug.cgi?id=67936

REGRESSION(r81225): ORWT should ignore reftests
https://bugs.webkit.org/show_bug.cgi?id=67936

> Tools/ChangeLog:10
> +	   (isUsedInReftest):
> +	   (findTestsToRun):

(isUsedInReftest): $filename should be the first parameter
(findTestsToRun): run test if it isn't reftest