[webkit-reviews] review granted: [Bug 57185] drop event isn't fired for contentEditable in edit drag : [Attachment 122366] fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 17 01:35:14 PST 2012


Adam Barth <abarth at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 57185: drop event isn't fired for contentEditable in edit drag
https://bugs.webkit.org/show_bug.cgi?id=57185

Attachment 122366: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=122366&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122366&action=review


This was not nearly as scary as it looked at first.  I'm not an expert here. 
Please let me know if you'd prefer to have someone more expert in this area
review your patch.

> Source/WebCore/page/EventHandler.cpp:1915
> +    bool result = false;

Should this be called "preventedDefault" rather than "result" ?


More information about the webkit-reviews mailing list