[webkit-reviews] review granted: [Bug 76425] [Internals] Should be able to access corresponding Document object. : [Attachment 122723] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 76425: [Internals] Should be able to access corresponding Document object.
https://bugs.webkit.org/show_bug.cgi?id=76425

Attachment 122723: Patch
https://bugs.webkit.org/attachment.cgi?id=122723&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122723&action=review


> Source/WebCore/page/FrameDestructionObserver.cpp:42
> +

Looks like you've got an extra blank line here.

> Source/WebCore/page/FrameDestructionObserver.h:37
> +    void observe(Frame*);

I wonder if we should pick a longer name for this function given that this
class will be used as a base class for many other classes.  Maybe
"observeFrame" ?  I leave that up to your judgement.  (Please fix the Windows
build before landing.)