[webkit-reviews] review denied: [Bug 75306] ShadowContentElement query should be able to have fallback element. : [Attachment 122709] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 75306: ShadowContentElement query should be able to have fallback element.
https://bugs.webkit.org/show_bug.cgi?id=75306

Attachment 122709: Patch
https://bugs.webkit.org/attachment.cgi?id=122709&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122709&action=review


Could you test some nested cases?

> Source/WebCore/ChangeLog:24
> +	     Changed the order of calculation a bit.

Please explain the change concretely.

> Source/WebCore/dom/NodeRenderingContext.cpp:86
> +	       if (!shadowContentElement->inclusions() ||
!shadowContentElement->inclusions()->first()) {

Can inclusions() be null? Is it OK to take the case as a fallback?