[webkit-reviews] review denied: [Bug 69210] CSS 2.1 failure: inline-box-002.htm fails : [Attachment 122576] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 69210: CSS 2.1 failure: inline-box-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=69210

Attachment 122576: Patch
https://bugs.webkit.org/attachment.cgi?id=122576&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122576&action=review


One comment:

> Source/WebCore/rendering/RenderInline.cpp:251
> +	   if (isRelPositioned())
> +	       newStyle->setPosition(RelativePosition);

Don't you also need to set the block to be relatively positioned if an ancestor
inline is relatively positioned? Seems like you might need to do that when
splitting ancestors.

Make a test case with <span style="position:relative;
left:50px;top:50px"><span><i><b>etc.etc. <div>HAHA!

to see what I mean.