[webkit-reviews] review granted: [Bug 76270] Implement offline web applications abort API : [Attachment 122543] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 16 11:04:45 PST 2012
Alexey Proskuryakov <ap at webkit.org> has granted huangxueqing
<huangxueqing at baidu.com>'s request for review:
Bug 76270: Implement offline web applications abort API
https://bugs.webkit.org/show_bug.cgi?id=76270
Attachment 122543: patch
https://bugs.webkit.org/attachment.cgi?id=122543&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122543&action=review
r=me
> Source/WebCore/loader/appcache/ApplicationCacheGroup.h:80
> + void abort(Frame*);
I'd just make this function not take any argument. That said, how we link
update to a frame is so broken that it doesn't matter much.
More information about the webkit-reviews
mailing list