[webkit-reviews] review requested: [Bug 12499] External <use> xlink:href references do not work : [Attachment 122648] Proposed patch

[bugzilla-daemon at webkit.org]

Renata Hodovan <reni at webkit.org> has asked  for review:
Bug 12499: External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Attachment 122648: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=122648&action=review

------- Additional Comments from Renata Hodovan <reni at webkit.org>
This patch is still a draft. It needs better changelog ofc and maybe more
tests, etc...
The following are contained in this version:
 * External resoruces are supported recursively too.
 * Self referencing is handled.
 * For some reason I needed to pass the ancestor's frame around (instead the
security origin wouldn't be set to the proper value). I'm not sure wheter it's
the correct solution.
 * There are two functions in CachedResourceLoader (checkInsecureContent() and
canRequest()) which are dealing with security settings. I tried to understand
what are they for but I guess it needs more refinement.
 * Tests are added to check self referencing, self referencing across documents
(these come from w3.org) and referencing of resources over documents.