[webkit-reviews] review granted: [Bug 74359] WebAudio: Optimize AudioChannel::maxAbsValue(). : [Attachment 122496] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 16 08:57:25 PST 2012


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 74359: WebAudio: Optimize AudioChannel::maxAbsValue().
https://bugs.webkit.org/show_bug.cgi?id=74359

Attachment 122496: Patch
https://bugs.webkit.org/attachment.cgi?id=122496&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122496&action=review


> Source/WebCore/platform/audio/VectorMath.cpp:101
> +void vmaxmgv(const float *sourceP, int sourceStride, float *maxP, size_t
framesToProcess)

Aren't the *s on the wrong side?

> Source/WebCore/platform/audio/VectorMath.cpp:423
> +void vmaxmgv(const float *sourceP, int sourceStride, float *maxP, size_t
framesToProcess)

Ditto.

> Source/WebCore/platform/audio/VectorMath.h:41
> +void vmaxmgv(const float *sourceP, int sourceStride, float *maxP, size_t
framesToProcess);

Ditto.


More information about the webkit-reviews mailing list