[webkit-reviews] review granted: [Bug 76383] Web Inspector: do not merge iframes into a single DOM hierarchy. : [Attachment 122638] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 76383: Web Inspector: do not merge iframes into a single DOM hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=76383

Attachment 122638: Patch
https://bugs.webkit.org/attachment.cgi?id=122638&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122638&action=review


> Source/WebCore/ChangeLog:29
> +	   ():

You should fix this.

> Source/WebCore/inspector/front-end/DOMAgent.js:39
> +    this._domAgent = domAgent;

Why does domAgent need passed to everyone? WebInspector.domAgent is a
singleton.

> Source/WebCore/inspector/front-end/DOMAgent.js:67
> +	   this.children = [this._contentDocument];

Why does children contain itself? Shouldn't it stay empty so it can be
populated with the root DOM nodes?

> Source/WebCore/inspector/front-end/DOMAgent.js:508
>      this.documentURL;

Why is this here? Is it for the compiler?

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:-1524
> -	       case Node.DOCUMENT_NODE:
> -		  
info.titleDOM.appendChild(document.createTextNode("Document"));
> -		   break;
> -

Because it was never used?