[webkit-reviews] review requested: [Bug 76069] [GTK] ATK text-caret-moved and text-selection-changed events not being emitted : [Attachment 122637] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 76069: [GTK] ATK text-caret-moved and text-selection-changed events not
being emitted
https://bugs.webkit.org/show_bug.cgi?id=76069

Attachment 122637: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=122637&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #5)
> It seems this is not properly fixed yet. The patch caused trouble in the GTK
64 bit Debug bot, so I had to roll it out:
https://bugs.webkit.org/show_bug.cgi?id=76267

The attached new patch uses positionBeforeNode instead of firstPositionInNode
(which should be equivalent in this case, while not making that ASSERT fail)
and also takes special care on the fact that the reference object passed to
objectFocusedAndCaretOffsetUnignored should either be the same object being
actually considered (and returned) or an ascendant, but never a descendant of
such actual object.

I tested it in a debug 64bit build and seems to pass both the unit and layout
tests. That must mean something