[webkit-reviews] review denied: [Bug 76376] CSSStyleSelector: Factor 'isCacheable' flag out of MatchedResult. : [Attachment 122617] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Andreas Kling <kling at webkit.org>'s
request for review:
Bug 76376: CSSStyleSelector: Factor 'isCacheable' flag out of MatchedResult.
https://bugs.webkit.org/show_bug.cgi?id=76376

Attachment 122617: Patch
https://bugs.webkit.org/attachment.cgi?id=122617&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=122617&action=review


> Source/WebCore/css/CSSStyleSelector.cpp:821
> +void CSSStyleSelector::matchAllRules(MatchResult& result, bool&
resultIsCacheable)

I think I would prefer keeping everything in the MatchResult and instead
factoring the ranges out to a separate struct that can be used in the matched
declaration cache (instead of the full MatchResult).