[webkit-reviews] review granted: [Bug 76352] CSSCanvasValue can't be renamed, enforce this at compile-time. : [Attachment 122578] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 76352: CSSCanvasValue can't be renamed, enforce this at compile-time.
https://bugs.webkit.org/show_bug.cgi?id=76352

Attachment 122578: Patch
https://bugs.webkit.org/attachment.cgi?id=122578&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=122578&action=review


> Source/WebCore/css/CSSParser.cpp:6454
>      CSSParserValue* a = args->current();
>      if (!a || a->unit != CSSPrimitiveValue::CSS_IDENT)

Maybe use a more descriptive name than 'a' since you are here.

> Source/WebCore/css/CSSParser.cpp:6457
> -    canvas = result;
> +
> +    canvas = CSSCanvasValue::create(a->string);

I wouldn't add an empty line here.