[webkit-reviews] review requested: [Bug 76284] [GTK] Include gtk+3 in the jhbuild modules : [Attachment 122609] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 16 03:27:14 PST 2012


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 76284: [GTK] Include gtk+3 in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=76284

Attachment 122609: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=122609&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching new patch including GTK+ 3.0.12 (version currently present in the GTK
64bit debug bot) in the moduleset. Also, added as dependency for
"gnome-icon-theme", as per the deps-graph in GNOME's modulesets.

Last, I added the '-lm' flag manually in jhbuildrc, since for some reason the
tarball for GTK 3.0.12 was not "smart enough" for adding it when linking the
tests,so it would fail (at least for me) due to not being able to find floor()
function :/. If there's a better way to workaround this issue, I'm all ears.


More information about the webkit-reviews mailing list