[webkit-reviews] review denied: [Bug 75512] [EFL] Implement the hit test result's bounding rect : [Attachment 121385] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 75512: [EFL] Implement the hit test result's bounding rect
https://bugs.webkit.org/show_bug.cgi?id=75512

Attachment 121385: Patch
https://bugs.webkit.org/attachment.cgi?id=121385&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121385&action=review


> Source/WebKit/efl/ewk/ewk_frame.cpp:691
> +    hitTest->bounding_box = result.innerNonSharedNode() ?
result.innerNonSharedNode()->renderer()->absoluteBoundingBoxRect() :
WebCore::IntRect();

I know you just follow what other ports do. But it is really unfortunate to see
this
- layering violation: accessing the render object.
- null check which should be done by HItTestResult.

Could you extract this function as a part of HistTestResult method?