[webkit-reviews] review denied: [Bug 74014] Allow deviceScaleFactor to be set from window.internals : [Attachment 121289] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 16 00:45:37 PST 2012


MORITA Hajime <morrita at google.com> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 74014: Allow deviceScaleFactor to be set from window.internals
https://bugs.webkit.org/show_bug.cgi?id=74014

Attachment 121289: Patch
https://bugs.webkit.org/attachment.cgi?id=121289&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
Please use LayoutTestController instead of Internals because setting/getting
the device scale factor can be done by WebKit public API.
The Internals object is for inspecting hidden, internal state of WebCore.

It's OK to take care of Chromium for now, skip for other ports if you file bugs
for them.


More information about the webkit-reviews mailing list