[webkit-reviews] review requested: [Bug 76043] CSSStyleSelector constructor and appendAuthorStylesheets() contain duplicated code : [Attachment 122579] new patch, smaller

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 15 18:19:54 PST 2012


Roland Steiner <rolandsteiner at chromium.org> has asked  for review:
Bug 76043: CSSStyleSelector constructor and appendAuthorStylesheets() contain
duplicated code
https://bugs.webkit.org/show_bug.cgi?id=76043

Attachment 122579: new patch, smaller
https://bugs.webkit.org/attachment.cgi?id=122579&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
New, smaller patch. Adds a const-accessor for the vector to StyleSheetList.
Perhaps not terribly elegant, but it's a) const only and b) there's a precedent
with StyleSheetList::swap(). This way no iterators are necessary (still using
'StyleSheetVector' within StyleSheetList for consistency).


More information about the webkit-reviews mailing list