[webkit-reviews] review granted: [Bug 76350] ScriptRunner should also keep references to pending async scripts : [Attachment 122575] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 76350: ScriptRunner should also keep references to pending async scripts
https://bugs.webkit.org/show_bug.cgi?id=76350

Attachment 122575: Patch
https://bugs.webkit.org/attachment.cgi?id=122575&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122575&action=review


> Source/WebCore/dom/ScriptElement.cpp:236
> +	   m_element->document()->scriptRunner()->queueScriptForExecution(this,
m_cachedScript, ScriptRunner::ASYNC_EXECUTION);

These enum values shouldn't be in ALL_CAPS, but that's a pre-existing problem.

> Source/WebCore/dom/ScriptRunner.cpp:102
> +    default:
> +	   ASSERT_NOT_REACHED();

In WebKit, we leave off the default cases for enums so the compiler can
complain when we forget one.