[webkit-reviews] review canceled: [Bug 76349] [chromium] Allow modification of size of partially occluded quads. [not for review, yet] : [Attachment 122573] Patch

[bugzilla-daemon at webkit.org]

W. James MacLean <wjmaclean at chromium.org> has canceled W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 76349: [chromium] Allow modification of size of partially occluded quads.
[not for review, yet]
https://bugs.webkit.org/show_bug.cgi?id=76349

Attachment 122573: Patch
https://bugs.webkit.org/attachment.cgi?id=122573&action=review

------- Additional Comments from W. James MacLean <wjmaclean at chromium.org>
This patch is not quite done yet. I would appreciate comments on the approach,
specifically w.r.t. to the two issues mentioned below.

1) It seems ugly having to have the special modification for CCTileDrawQuad,
yet it fails without it. When we re-size the quad, we need to say where the new
quad starts in the texture ...

We can't just do this via the clip rect, as this is shared with all quads in
the layer.

2) The code specific to CCTileDrawQuad in CCQuadCuller seems to invoke some
sort of pointer error when running CCQuadCullerTest.verifyCullCenterTileOnly
(which is the only CCQuadCuller unit test that will invoke the quad resizing
logic). When run, it gives the following (truncated) error dump:

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from CCQuadCullerTest
[ RUN	   ] CCQuadCullerTest.verifyCullCenterTileOnly
*** glibc detected *** out/Debug/webkit_unit_tests: munmap_chunk(): invalid
pointer: 0x000000000242c640 ***
======= Backtrace: =========
/lib/libc.so.6(+0x775b6)[0x7f90bc03f5b6]
.
.
.

183:0115/163925:532185838963:ERROR:process_util_posix.cc(138)] Received signal
6
	base::debug::StackTrace::StackTrace() [0x7f90c4675492]
	base::(anonymous namespace)::StackDumpSignalHandler() [0x7f90c46d2cfd]
	0x7f90bbffbaf0
	0x7f90bbffba75
	0x7f90bbfff5c0
	0x7f90bc0354fb
	0x7f90bc03f5b6
	WTF::deleteOwnedPtr<>() [0x7f90c56b9567]
	WTF::OwnPtr<>::~OwnPtr() [0x7f90c56b954d]
	WTF::VectorDestructor<>::destruct() [0x7f90c56b9466]
	WTF::VectorTypeOperations<>::destruct() [0x7f90c56b9360]
	WTF::Vector<>::shrink() [0x7f90c56b90ef]
	WTF::Vector<>::~Vector() [0x7f90c56b8e09]
	(anonymous
namespace)::CCQuadCullerTest_verifyCullCenterTileOnly_Test::TestBody()
[0x7f90c56b720c]
	testing::internal::HandleSehExceptionsInMethodIfSupported<>()
[0x7f90c5a6af05]