[webkit-reviews] review requested: [Bug 76177] SVG group getBBox returns 0, 0, 0, 0 for a group of perpendicular paths : [Attachment 122548] Fix getBBox for perpendicular paths

[bugzilla-daemon at webkit.org]

Philip Rogers <pdr at google.com> has asked  for review:
Bug 76177: SVG group getBBox returns 0,0,0,0 for a group of perpendicular paths
https://bugs.webkit.org/show_bug.cgi?id=76177

Attachment 122548: Fix getBBox for perpendicular paths
https://bugs.webkit.org/attachment.cgi?id=122548&action=review

------- Additional Comments from Philip Rogers <pdr at google.com>
This patch contains two fixes for failures exposed in my previous patch:
1) We need to special-case the first bounding box in
SVGRendererSupport::computeContainerBoundingBoxes. What's happening is we start
with a bounding box of 0,0,0,0 and we add the union of all our child bounding
boxes. The problem is that the resulting bounding box will always start at x=0,
y=0, due to the initial bounding box of 0,0,0,0, so we need to special-case the
first child and set the initial bounding box to our first child's bounding box.


2) My previous patch had a mistake where I failed to transform a child's
bounding box using transform.mapRect().