[webkit-reviews] review denied: [Bug 76187] Add a check-webkit-style exception for GDBInterface.cpp : [Attachment 122539] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 14 03:35:55 PST 2012


Philippe Normand <pnormand at igalia.com> has denied Sanjoy Das
<thedigitalangel at gmail.com>'s request for review:
Bug 76187: Add a check-webkit-style exception for GDBInterface.cpp
https://bugs.webkit.org/show_bug.cgi?id=76187

Attachment 122539: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=122539&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122539&action=review


It is looking good! The last missing bit is a little unittest in
Tools/Scripts/webkitpy/style/checker_unittest.py maybe you can add it in
test_path_rules_specifier. To run the tests use test-webkitpy.

> Tools/ChangeLog:7
> +	   Unreviewed

The Reviewed by NOBODY (OOPS!). line should remain. It is transformed to
"Reviewed by Foo" by the commiter or the commit-queue bot.


More information about the webkit-reviews mailing list