[webkit-reviews] review denied: [Bug 76035] Add state attribute to history's dom interface. : [Attachment 122518] new try based on brady's suggestions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 13 16:50:57 PST 2012
Brady Eidson <beidson at apple.com> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 76035: Add state attribute to history's dom interface.
https://bugs.webkit.org/show_bug.cgi?id=76035
Attachment 122518: new try based on brady's suggestions
https://bugs.webkit.org/attachment.cgi?id=122518&action=review
------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122518&action=review
>> Source/WebCore/page/History.cpp:116
>> + ScriptValue& state = historyItem->deserializedStateObject();
>
> This is kind of subtle given that you're assign to a non-const reference.
>
> Maybe you should have historyItem do this work?
Not maybe - definitely!
More information about the webkit-reviews
mailing list