[webkit-reviews] review granted: [Bug 76233] test-webkitpy: should support classes and individual test names as well as modules : [Attachment 122347] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 13 13:02:14 PST 2012


Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 76233: test-webkitpy: should support classes and individual test names as
well as modules
https://bugs.webkit.org/show_bug.cgi?id=76233

Attachment 122347: Patch
https://bugs.webkit.org/attachment.cgi?id=122347&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122347&action=review


> Tools/Scripts/webkitpy/test/cat_unittest.py:-31
> -

This blank line should stay according to PEP8

> Tools/Scripts/webkitpy/test/main.py:261
> +	       if os.path.exists(os.path.join(os.path.dirname(d), relpath)):

I'm tempted to say we should go through filesystem here, but then again, that's
probably not needed.


More information about the webkit-reviews mailing list