[webkit-reviews] review denied: [Bug 76213] Web Inspector: Disconnecting the front-end does not disable profiling. : [Attachment 122420] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 13 06:54:57 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Konrad Piascik
<kpiascik at rim.com>'s request for review:
Bug 76213: Web Inspector: Disconnecting the front-end does not disable
profiling.
https://bugs.webkit.org/show_bug.cgi?id=76213

Attachment 122420: patch
https://bugs.webkit.org/attachment.cgi?id=122420&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122420&action=review


> Source/WebCore/inspector/InspectorController.cpp:236
> +    disableProfiler();

You should call disable() from within InspectorProfilerAgent::clearFrontend()
instead.


More information about the webkit-reviews mailing list