[webkit-reviews] review denied: [Bug 76019] Improve bit-packing of CSSValue, CSSPrimitiveValue and CSSValueList. : [Attachment 122162] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 76019: Improve bit-packing of CSSValue, CSSPrimitiveValue and CSSValueList.
https://bugs.webkit.org/show_bug.cgi?id=76019

Attachment 122162: Patch
https://bugs.webkit.org/attachment.cgi?id=122162&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
I'm not convinced we should be introducing bitfield refcounts, it feels like
we're scratching at something of a Pandora's box here:

- It introduces an arbitrary inconsistency in how many refs different objects
can have.
- It's no longer possible to take the address of a ref counter. (Something the
JSC JIT has used in the past, not sure if we'll need it again.)

The CSSPrimitiveValueBase change is great on its own.