[webkit-reviews] review granted: [Bug 76264] Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector. : [Attachment 122407] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 76264: Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and
IndexedDBModel, pass database names to inspector.
https://bugs.webkit.org/show_bug.cgi?id=76264

Attachment 122407: Patch
https://bugs.webkit.org/attachment.cgi?id=122407&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122407&action=review


> Source/WebCore/inspector/Inspector.json:111
> +		       { "name": "securityOrigin", "type": "string",
"description": "Frame document's security origin." },

Should we make this field optional?

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

2012

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:110
> +	   RefPtr<InspectorObject> result = InspectorObject::create();

You should use new generated API for front-end messages.

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:166
> +    m_enabled = true;

I don't introduce these unless performance matters.

> Source/WebCore/inspector/InspectorIndexedDBAgent.h:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

2012

> Source/WebCore/inspector/front-end/IndexedDBModel.js:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

2012

> Source/WebCore/inspector/front-end/IndexedDBModel.js:203
> +    

Extra blank line.