[webkit-reviews] review granted: [Bug 74978] [Skia] [Coverity] Fix an uninitialized member variable : [Attachment 120120] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 13 03:42:55 PST 2012
Nikolas Zimmermann <zimmermann at kde.org> has granted Rachel Blum
<groby at chromium.org>'s request for review:
Bug 74978: [Skia] [Coverity] Fix an uninitialized member variable
https://bugs.webkit.org/show_bug.cgi?id=74978
Attachment 120120: Patch
https://bugs.webkit.org/attachment.cgi?id=120120&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
A quick grep shows following users of m_clip:
PlatformContextSkia.cpp:
canvas()->getTotalMatrix().mapRect(&m_state->m_clip);
PlatformContextSkia.cpp: applyClipFromImage(m_state->m_clip,
m_state->m_imageBufferClip);
which are relevant.
The first place, sets m_clip, but the restore() call actually reads from
m_clip, if m_imageBufferClip is non null.
Is it possible to create a layout test triggering this? Anyhow, still r=me,
this is straight-forward. But if it had a test, it would be superb.
More information about the webkit-reviews
mailing list