[webkit-reviews] review granted: [Bug 76242] [Mac][DRT] Should support --no-timeout : [Attachment 122367] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 12 22:28:33 PST 2012
Darin Adler <darin at apple.com> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 76242: [Mac][DRT] Should support --no-timeout
https://bugs.webkit.org/show_bug.cgi?id=76242
Attachment 122367: Patch
https://bugs.webkit.org/attachment.cgi?id=122367&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122367&action=review
Looks OK.
> Tools/DumpRenderTree/mac/DumpRenderTree.mm:1109
> + ASSERT(timer);
> + waitToDumpWatchdog = timer;
Should also ASSERT(!waitToDumpWatchdog)
More information about the webkit-reviews
mailing list