[webkit-reviews] review denied: [Bug 67109] [EFL] Weak scroll feature : [Attachment 113442] patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Kamil Blank
<k.blank at samsung.com>'s request for review:
Bug 67109: [EFL] Weak scroll feature
https://bugs.webkit.org/show_bug.cgi?id=67109

Attachment 113442: patch
https://bugs.webkit.org/attachment.cgi?id=113442&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=113442&action=review


See WebKit EFL coding style : http://trac.webkit.org/wiki/EFLWebKitCodingStyle

> Source/WebKit/efl/ewk/ewk_frame.cpp:78
> +	   int dx, dy;

Do not use abbreviation.

> Source/WebKit/efl/ewk/ewk_frame.cpp:79
> +	   Eina_Bool moving_viewport_allowed : 1;

Do not use '_' except for public APIs.

> Source/WebKit/efl/ewk/ewk_frame.cpp:81
> +    } queued_scrolls;

s/queued_scrolls/queuedScrolls/g

> Source/WebKit/efl/ewk/ewk_private.h:229
> +Eina_Bool ewk_frame_scroll_moving_viewport_allowed_get(Evas_Object* o);

Use ewkFrame instead of o. It looks this patch needs to be rebased.